-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter: reduce memory malloc to avoid too much CPU overhead (#1854) #1863
sorter: reduce memory malloc to avoid too much CPU overhead (#1854) #1863
Conversation
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9a1a01a
|
Codecov Report
@@ Coverage Diff @@
## release-5.0 #1863 +/- ##
================================================
Coverage ? 54.0773%
================================================
Files ? 153
Lines ? 16138
Branches ? 0
================================================
Hits ? 8727
Misses ? 6490
Partials ? 921 |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-kafka-tests |
This is an automated cherry-pick of #1854
What problem does this PR solve?
ref: #1853
What is changed and how it works?
Since the access ofh.heap
is not concurrent, we can use the sameslice
The heap will be used in an async pool. We choose a conservative initialize size for sort heap slice.
1GB
?Check List
Tests
Release note