-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owner: Fix gcttl bug (#1861) #1871
Owner: Fix gcttl bug (#1861) #1871
Conversation
… current ts - gcttl
Fix unit test by replace nonexistent functions.
…ot/ticdc into cherry-pick-1861-to-release-4.0
/lgtm |
@asddongmen: Thanks for your review. The bot only counts In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@leoppro: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-leak-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 012cb9a
|
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1871 +/- ##
===================================================
- Coverage 53.7661% 53.6032% -0.1630%
===================================================
Files 153 163 +10
Lines 15958 17290 +1332
===================================================
+ Hits 8580 9268 +688
- Misses 6475 7042 +567
- Partials 903 980 +77 |
This is an automated cherry-pick of #1861
What problem does this PR solve?
#1839
What is changed and how it works?
Modify the calculation method of MinGCSafePoint (the lower bound of CDC's gcSafePoint)
Before:
MinGCSafePoint = curentTs - gcTTL
After:
MinGCSafePoint = min(curentTs - gcTTL, pdSafePoint)
Check List
Tests
Side effects
Related changes
Release note