Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed: filter out the temporary table schema change #1923

Closed
wants to merge 1 commit into from

Conversation

tiancaiamao
Copy link

What problem does this PR solve?

We are implementing temporary table

Write on the temporary table do not generate any key-value to TiKV,
but for the global temporary table, the table meta data is generated.

Our local temporary table will be MySQL compatible.
Our global temporary table is an extension of MySQL, so it's not supposed to sync to a MySQL downstream.
This extension should make the CDC processing fail.

What is changed and how it works?

Filter the create global temporary table DDL changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Seems the integration test environment is so ... complex.
This is just one line change, could we skip the test?

Side effects

  • Breaking backward compatibility

Update the parser, the model.Table is updated, this should not affect the compatibility because the lack of the field would be set the default value

Release note

  • No release note

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 3, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2021
@tiancaiamao
Copy link
Author

Without changes, the behaviour is the same with other feature(like auto random etc):
Sync TiDB to MySQL with tidb-specific feature result in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants