Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: reduce memory consumption by reducing channel sizes (#1999) #2011

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1999

What problem does this PR solve?

  • TiCDC can OOM frequently on machines with memory less than 16GB.

What is changed and how it works?

  • Decreased the channel sizes in two places.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Reduce unnecessary memory consumption

@ti-chi-bot ti-chi-bot added component/kv-client TiKV kv log client component. status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jun 10, 2021
@ti-chi-bot ti-chi-bot requested a review from lonng June 10, 2021 03:07
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2021
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 10, 2021
@lonng lonng added this to the v4.0.14 milestone Jun 10, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 6, 2021
@amyangfei amyangfei force-pushed the cherry-pick-1999-to-release-4.0 branch from 5f49c63 to 16b8968 Compare July 8, 2021 03:06
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 16b8968

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2011 (9dcdaf1) into release-4.0 (753073a) will decrease coverage by 1.1820%.
The diff coverage is 58.8892%.

@@                 Coverage Diff                 @@
##           release-4.0      #2011        +/-   ##
===================================================
- Coverage      53.7661%   52.5840%   -1.1821%     
===================================================
  Files              153        165        +12     
  Lines            15958      17511      +1553     
===================================================
+ Hits              8580       9208       +628     
- Misses            6475       7334       +859     
- Partials           903        969        +66     

@ti-chi-bot ti-chi-bot merged commit d7802e0 into pingcap:release-4.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants