-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter: fix panic when getting memory pressure fails #2014
Conversation
/run-all-tests |
/run-unit-test |
/run-unit-tests |
@jinlingchristopher: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 47b2559
|
/run-kafka-tests |
/run-kafka-tests |
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
================================================
- Coverage 54.0780% 53.7714% -0.3066%
================================================
Files 156 164 +8
Lines 16589 17394 +805
================================================
+ Hits 8971 9353 +382
- Misses 6667 7065 +398
- Partials 951 976 +25 |
In response to a cherrypick label: new pull request created: #2023. |
In response to a cherrypick label: new pull request created: #2024. |
In response to a cherrypick label: new pull request created: #2025. |
What problem does this PR solve?
/proc/meminfo
fails to open, TiCDC will panic because of inappropriate error handling. This usually happens when the OS does not allow TiCDC any more file descriptors.What is changed and how it works?
Check List
Tests
Related changes
Release note
/proc/meminfo