Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: fix panic when getting memory pressure fails #2014

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 10, 2021

What problem does this PR solve?

  • When /proc/meminfo fails to open, TiCDC will panic because of inappropriate error handling. This usually happens when the OS does not allow TiCDC any more file descriptors.

What is changed and how it works?

  • Fixed error handling when reading system memory pressure.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix panic when TiCDC fails to read /proc/meminfo

@liuzix liuzix added status/ptal Could you please take a look? type/bugfix This PR fixes a bug. internal-test release-blocker This issue blocks a release. Please solve it ASAP. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 10, 2021
@liuzix liuzix added this to the v5.1.0 milestone Jun 10, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 10, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 10, 2021

/run-unit-test

@liuzix
Copy link
Contributor Author

liuzix commented Jun 10, 2021

/run-unit-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@ti-chi-bot
Copy link
Member

@jinlingchristopher: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 47b2559

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests
/run-integration-tests

@overvenus
Copy link
Member

/run-kafka-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2014 (3c29b23) into master (b6d58ef) will decrease coverage by 0.3065%.
The diff coverage is 64.3364%.

@@               Coverage Diff                @@
##             master      #2014        +/-   ##
================================================
- Coverage   54.0780%   53.7714%   -0.3066%     
================================================
  Files           156        164         +8     
  Lines         16589      17394       +805     
================================================
+ Hits           8971       9353       +382     
- Misses         6667       7065       +398     
- Partials        951        976        +25     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2023.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2024.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. release-blocker This issue blocks a release. Please solve it ASAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants