-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDC Server support data-dir (#1879) #2070
CDC Server support data-dir (#1879) #2070
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve in advance, please merge this PR once it's ready.
/run-all-tests |
/run-unit-tests |
/run-all-tests |
3 similar comments
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
…ti-chi-bot/ticdc into cherry-pick-1879-to-release-5.0--
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b010cca
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
1 similar comment
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…ti-chi-bot/ticdc into cherry-pick-1879-to-release-5.0--
Merge canceled because a new commit is pushed. |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #2070 +/- ##
================================================
Coverage ? 53.9479%
================================================
Files ? 164
Lines ? 17680
Branches ? 0
================================================
Hits ? 9538
Misses ? 7128
Partials ? 1014 |
This is an automated cherry-pick of #1879
What problem does this PR solve?
This PR makes TiCDC support
--data-dir
at the server level.What is changed and how it works?
--data-dir
is supported at the server level, default to""
, if not set, it will be set by conditions:/tmp/cdc_data
will be set as default data-dir--sort-dir
set, choose the valid one with the largest available space as data-dir.--sort-dir
set at both server level and changefeed level won't take effect, and default to/tmp/sorter
, this means it can not be changed by both command flag or config file/{data-dir}/tmp/sorter
Check List
Tests
Code changes
Side effects
Related changes
Release note