Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client,server: better err msg when PD endpoint missing certificate #2138

Merged
merged 12 commits into from
Jun 29, 2021
Merged

client,server: better err msg when PD endpoint missing certificate #2138

merged 12 commits into from
Jun 29, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/1973

What is changed and how it works?

Add better err msg.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Better err msg when PD endpoint missing certificate

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2021
@Rustin170506
Copy link
Member Author

I'm not sure we need a more detailed error message (e.g. prompting the user to use parameters to specify a certificate), suggestions welcome!

@Rustin170506
Copy link
Member Author

Also, should we check that it is a valid URL first?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@zier-one zier-one added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 24, 2021
lonng
lonng reviewed Jun 28, 2021
View reviewed changes
cmd/server.go Outdated Show resolved Hide resolved
lonng
lonng reviewed Jun 28, 2021
View reviewed changes
cmd/client.go Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 requested a review from lonng June 28, 2021 12:02
@Rustin170506
Copy link
Member Author

Rustin170506 commented Jun 28, 2021 •
edited
Loading

/hold

Code could be better.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2021
@Rustin170506
Copy link
Member Author

/unhold

Ready for review.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 249e537

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@Rustin170506
Copy link
Member Author

/run-kafka-integration-tests

@Rustin170506
Copy link
Member Author

/run-kafka-tests

@Rustin170506
Copy link
Member Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 3fd3637 into pingcap:master Jun 29, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2184.

@Rustin170506 Rustin170506 deleted the rustin-patch-missing branch June 29, 2021 05:22
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2185.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2186.

ti-chi-bot added a commit that referenced this pull request Jul 9, 2021
@ti-chi-bot
client,server: better err msg when PD endpoint missing certificate (#…
bb4e768 
…2138) (#2186)
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Jul 9, 2021
@Rustin170506 @3AceShowHand
client,server: better err msg when PD endpoint missing certificate (p…
8e09d54 
…ingcap#2138)
lonng pushed a commit that referenced this pull request Jul 12, 2021
@ti-chi-bot
client,server: better err msg when PD endpoint missing certificate (#…
5a947a3 
…2138) (#2184)
ti-chi-bot added a commit that referenced this pull request Jul 20, 2021
@ti-chi-bot
client,server: better err msg when PD endpoint missing certificate (#…
a73a83a 
…2138) (#2185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message when not passing certificate paths correctly with HTTPS PD URI
6 participants
@Rustin170506 @ti-chi-bot @amyangfei @lonng @overvenus @zier-one