Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: cherry-pick capture-session-ttl config into release-4.0 #2169

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

This is part of #1540, close #2148

What is changed and how it works?

Add capture-session-ttl in server config

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Add capture-session-ttl in cdc server config

@amyangfei amyangfei added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label Jun 28, 2021
@amyangfei amyangfei added this to the v4.0.14 milestone Jun 28, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2021
@ti-chi-bot
Copy link
Member

@jinlingchristopher: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei added type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. and removed needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Jun 28, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 29, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2021
Copy link
Contributor

@ben1009 ben1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@ti-chi-bot
Copy link
Member

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

💪🏻

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@leoppro: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand 3AceShowHand added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2169 (42a6698) into release-4.0 (753073a) will decrease coverage by 0.1649%.
The diff coverage is 62.9384%.

@@                 Coverage Diff                 @@
##           release-4.0      #2169        +/-   ##
===================================================
- Coverage      53.7661%   53.6011%   -0.1650%     
===================================================
  Files              153        163        +10     
  Lines            15958      17300      +1342     
===================================================
+ Hits              8580       9273       +693     
- Misses            6475       7050       +575     
- Partials           903        977        +74     

@3AceShowHand 3AceShowHand merged commit 7713b97 into pingcap:release-4.0 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants