Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/client: don't resolve lock immediately after a region is initialized (#2235) #2265

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2235

What problem does this PR solve?

Fix #2188

What is changed and how it works?

Introduce a penalty mechanism

  • If TiCDC keeps receiving unchanged resolved-ts, increase the penalty.
  • If TiCDC receives a new resolved ts, reset the penalty to zero
  • Only resolve ts if the penalty is larger than threshold

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Don't resolve lock immediately after a region is initialized.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jul 12, 2021
@amyangfei amyangfei added this to the v5.0.4 milestone Jul 12, 2021
@amyangfei
Copy link
Contributor

/merge

1 similar comment
@amyangfei
Copy link
Contributor

/merge

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 14, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@b6d0954). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4be324c differs from pull request most recent head b739291. Consider uploading reports for the commit b739291 to get more accurate results

@@               Coverage Diff                @@
##             release-5.0      #2265   +/-   ##
================================================
  Coverage               ?   54.6261%           
================================================
  Files                  ?        166           
  Lines                  ?      19941           
  Branches               ?          0           
================================================
  Hits                   ?      10893           
  Misses                 ?       8003           
  Partials               ?       1045           

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6087a20

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5c29a5d into pingcap:release-5.0 Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants