-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeed: Fix cannot remove changefeed when err gcttl exceeded (#2429) #2455
changefeed: Fix cannot remove changefeed when err gcttl exceeded (#2429) #2455
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please resolve conflicts @3AceShowHand |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 28d1eac
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2455 +/- ##
===================================================
+ Coverage 53.7661% 55.1756% +1.4094%
===================================================
Files 153 164 +11
Lines 15958 19505 +3547
===================================================
+ Hits 8580 10762 +2182
- Misses 6475 7727 +1252
- Partials 903 1016 +113 |
This is an automated cherry-pick of #2429
What problem does this PR solve?
fix #2391
What is changed and how it works?
GcManager
interface, which can be used to create a mocked GcManager to help write unit-testCheck List
Tests
Code changes
Side effects
Related changes
Release note