Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: prohibit operating TiCDC clusters across major and minor versions (#2481) #2599

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2481

What problem does this PR solve?

Prohibit operating TiCDC clusters across major versions

What is changed and how it works?

Add version check for both TiDB cluster and TiCDC cluster.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
tiup playground v5.1.0 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // ok

tiup playground v5.0.3 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // error "CDC:ErrVersionIncompatible"

tiup playground v4.0.14 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // error "CDC:ErrVersionIncompatible"

// Or there is no TiCDC cluster
cdc cli --pd http://127.0.0.1:2379 capture list // error TiCDC cluster is unknown, please start TiCDC cluster

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

Prohibit operating TiCDC clusters across major and minor versions

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/cli CLI component. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Aug 20, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 21, 2021
@amyangfei amyangfei added this to the v5.1.2 milestone Aug 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a38a9d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit fea259b into pingcap:release-5.1 Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cli CLI component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants