-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv: reduce gRPC window size to avoid OOM (#2699) #2726
kv: reduce gRPC window size to avoid OOM (#2699) #2726
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ca269fa
|
/run-integration-tests |
/run-kafka-tests |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-kafka-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #2726 +/- ##
================================================
Coverage ? 56.1526%
================================================
Files ? 169
Lines ? 20674
Branches ? 0
================================================
Hits ? 11609
Misses ? 7937
Partials ? 1128 |
This is an automated cherry-pick of #2699
What problem does this PR solve?
Note: TiCDC in the following tests includes https://github.com/pingcap/ticdc/pull/2214.
Memory usage (pause sorter)
Tested with following changes
The last image shows TiKV snapshot is holded for a long time, because CDC scan is flow controlled. Through, I doubt if it will actually happen as TiCDC sorter can always make progress.
Performance
No significant difference.
Close #2673
What is changed and how it works?
Check List
Tests
Related changes
Release note