Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: refine alert rules (#3021) #3025

Merged
merged 1 commit into from
Oct 13, 2021
Merged

metrics: refine alert rules (#3021) #3025

merged 1 commit into from
Oct 13, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3021

What problem does this PR solve?

  • remove tikv_enabled_hibernate_regions.
  • remove ticdc_puller_entry_sorter_merge_duration_time_more_than_2s.
  • remove ticdc_puller_entry_sorter_sort_duration_time_more_than_2s.
  • tikv_cdc_min_resolved_ts_no_change_for_1m alerts only when there
    are captured regions.
  • extend allowed scan duration from 30s to 10min for
    tikv_cdc_scan_duration_seconds_more_than_10min

Close tikv/tikv#11017
Close https://github.com/pingcap/ticdc/issues/2156

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Tested manually,

  1. Start cdc cluster
  2. Create a changefeed
  3. Pause the changefeed.
  4. Wait 2 minutes.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

Fix tikv_cdc_min_resolved_ts_no_change_for_1m keep firing when there is no changefeed.

@overvenus @ti-chi-bot
metrics: refine alert rules
a673bc9 
* remove tikv_enabled_hibernate_regions.
* remove ticdc_puller_entry_sorter_merge_duration_time_more_than_2s.
* remove ticdc_puller_entry_sorter_sort_duration_time_more_than_2s.
* tikv_cdc_min_resolved_ts_no_change_for_1m alerts only when there
  are captured regions.
* extend allowed scan duration from 30s to 10min for
  tikv_cdc_scan_duration_seconds_more_than_10min

Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 13, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@ti-chi-bot ti-chi-bot added component/metrics-logging Metrics and logging component. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Oct 13, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 13, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a673bc9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot ti-chi-bot merged commit e3ab61c into pingcap:release-5.1 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @overvenus @nongfushanquan