-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: remove per-table-memory-quota min value check (#3022) #3037
config: remove per-table-memory-quota min value check (#3022) #3037
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 503ae4a
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #3022
What problem does this PR solve?
Remove per-table-memory-quota min value check, because it is
possible to capture thousands of tables, and in this case, 6MB is
too large.
Also, it changes the default quota from 20MB to 10MB. Tests show
that no obvious bottleneck for 10MB.
Cc https://github.com/pingcap/ticdc/pull/2561
Metrics: https://gist.github.com/overvenus/183013d6b68c73f6b31d0dc1e5fb2bec
Check List
Tests
See above.
Related changes
Release note