Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: workaround the ErrPrewriteNotMatch by reconnection EventFeed RPC (#3019) #3091

Merged
merged 7 commits into from
Oct 26, 2021
Merged

kv: workaround the ErrPrewriteNotMatch by reconnection EventFeed RPC (#3019) #3091

merged 7 commits into from
Oct 26, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3019

What problem does this PR solve?

Close #2386, workaround the ErrPrewriteNotMatch by reconnection EventFeed RPC

What is changed and how it works?

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note 

Close gPRC stream and re-create it when meeting `ErrPrewriteNotMatch` to avoid duplicated request error

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/kv-client TiKV kv log client component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 19, 2021
Merged
@ti-chi-bot ti-chi-bot added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Oct 19, 2021
@amyangfei amyangfei added this to the v5.0.5 milestone Oct 19, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6ead2a3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

3 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei amyangfei mentioned this pull request Oct 26, 2021
Merged
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 6dcd9c0 into pingcap:release-5.0 Oct 26, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.5, v5.0.6 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CharlesCheung96 CharlesCheung96

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @zhouqiang-cl @CharlesCheung96 @nongfushanquan