Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: set max-message-bytes to initialize producer. (#3080) #3107

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3080

What problem does this PR solve?

Close #3081

This is a fix after #3002.

In #3002, we set 512M as the minimum max-message-size to initialize the sarama producer, which would batch small message then larger than broker's message.max.bytes, make the message failed to send.

If the user does not pass max-message-bytes when creating then changefeed, the producer use 512M, it's very likely larger than the broker's value. so we have to set the default value smaller, to 1M.

Also, set encoder's defaultMaxMessageBytes to 1M, to prevent encoded message too large, then reject by the client.

What is changed and how it works?

  • use custom max-message-size to initialize the producer.
  • set default MaxMessageSize to 1M.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

change Kafka sink default `MaxMessageBytes` to 1MB.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added component/sink Sink component. release-blocker This issue blocks a release. Please solve it ASAP. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 20, 2021
@ti-chi-bot ti-chi-bot added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Oct 20, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@89cc702). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #3107   +/-   ##
================================================
  Coverage               ?   57.0897%           
================================================
  Files                  ?        166           
  Lines                  ?      19627           
  Branches               ?          0           
================================================
  Hits                   ?      11205           
  Misses                 ?       7354           
  Partials               ?       1068           

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 21, 2021
@amyangfei amyangfei added this to the v5.0.5 milestone Oct 22, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b7fd211

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2021
@3AceShowHand
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 1d9364d into pingcap:release-5.0 Oct 22, 2021
@zhouqiang-cl zhouqiang-cl removed this from the v5.0.5 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants