-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeed: fix changefeed does not fast fail when occur ErrGCTTLExceeded error (#3120) #3134
changefeed: fix changefeed does not fast fail when occur ErrGCTTLExceeded error (#3120) #3134
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-kafka-tests |
/run-kafka-tests |
/run-integration-tests |
1 similar comment
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3134 +/- ##
===================================================
+ Coverage 53.7661% 57.4464% +3.6803%
===================================================
Files 153 165 +12
Lines 15958 19573 +3615
===================================================
+ Hits 8580 11244 +2664
- Misses 6475 7250 +775
- Partials 903 1079 +176 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5a21b38
|
This is an automated cherry-pick of #3120
What problem does this PR solve?
close #3111
What is changed and how it works?
ErrGCTTLExceeded
as a fast fail error.changefeed.tick()
check stale checkpointTs beforefeedStateManager.ShouldRunning()
to ensure an error or stopped changefeed also be checked. Otherwise, a stoped or error changefeed will not be fast failed because thetick()
is return before the changefeed's checkpointTs be cheked.Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
Has exported function/method change
Has exported variable/fields change
Related changes
Release note