Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed: fix changefeed does not fast fail when occur ErrGCTTLExceeded error (#3120) #3134

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3120

What problem does this PR solve?

close #3111

What is changed and how it works?

  1. Add ErrGCTTLExceeded as a fast fail error.
  2. In changefeed.tick() check stale checkpointTs before feedStateManager.ShouldRunning() to ensure an error or stopped changefeed also be checked. Otherwise, a stoped or error changefeed will not be fast failed because the tick() is return before the changefeed's checkpointTs be cheked.

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

    1. Start up stream tidb cluster, and set tikv_gc_run_interval to 10s.
    2. Start a CDC cluster with server config gc-ttl = 120 (2 minutes).
    3. create a changefeed and then pause it.
    4. after about 10 to 20 minutes, the changefeed was failed.
      image
  • Has exported function/method change

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch

Release note

bugfix: fix changefeed does not fast fail when occur ErrGCTTLExceeded error.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/replica-model Replication model component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Oct 26, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 26, 2021
@asddongmen
Copy link
Contributor

/run-kafka-tests
/run-integration-tests

@asddongmen
Copy link
Contributor

/run-kafka-tests
/run-integration-tests
/run-unit-tests

@asddongmen
Copy link
Contributor

/run-integration-tests

1 similar comment
@asddongmen
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #3134 (5a21b38) into release-4.0 (753073a) will increase coverage by 3.6803%.
The diff coverage is 67.2733%.

@@                 Coverage Diff                 @@
##           release-4.0      #3134        +/-   ##
===================================================
+ Coverage      53.7661%   57.4464%   +3.6803%     
===================================================
  Files              153        165        +12     
  Lines            15958      19573      +3615     
===================================================
+ Hits              8580      11244      +2664     
- Misses            6475       7250       +775     
- Partials           903       1079       +176     

@amyangfei amyangfei added this to the v4.0.16 milestone Oct 28, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5a21b38

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2021
@ti-chi-bot ti-chi-bot merged commit 35f2d40 into pingcap:release-4.0 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants