-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github(ticdc): adjust avro integration test tikv log-rotation-size to 500MB #3166
github(ticdc): adjust avro integration test tikv log-rotation-size to 500MB #3166
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -9,6 +9,7 @@ | |||
log-level = "error" | |||
# file to store log, write to stderr if it's empty. | |||
# log-file = "" | |||
log-rotation-size="500MB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the log-level
is error
, it is not reasonable that TiKV writes so many error logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We overwrite it in cli flags. See the docker compose file.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 365b4dc
|
Codecov Report
@@ Coverage Diff @@
## master #3166 +/- ##
================================================
- Coverage 57.2251% 56.8226% -0.4025%
================================================
Files 163 210 +47
Lines 19453 22667 +3214
================================================
+ Hits 11132 12880 +1748
- Misses 7261 8471 +1210
- Partials 1060 1316 +256 |
In response to a cherrypick label: new pull request created: #3181. |
In response to a cherrypick label: new pull request created: #3182. |
In response to a cherrypick label: new pull request created: #3183. |
In response to a cherrypick label: new pull request created: #3184. |
…
What problem does this PR solve?
part of https://github.com/pingcap/ticdc/issues/2805
What is changed and how it works?
adjust avro integration test tikv log-rotation-size to 500MB.
Check List
Tests
Code changes
None
Side effects
None
Related changes
None
Release note