Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github(ticdc): adjust avro integration test tikv log-rotation-size to 500MB #3166

Merged

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/2805

What is changed and how it works?

adjust avro integration test tikv log-rotation-size to 500MB.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes
None

Release note

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 28, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2021
@@ -9,6 +9,7 @@
log-level = "error"
# file to store log, write to stderr if it's empty.
# log-file = ""
log-rotation-size="500MB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the log-level is error, it is not reasonable that TiKV writes so many error logs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We overwrite it in cli flags. See the docker compose file.

@amyangfei amyangfei added this to the v5.3.0 milestone Oct 29, 2021
@amyangfei amyangfei added the component/test Unit tests and integration tests component. label Oct 29, 2021
@liuzix liuzix added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 29, 2021
@liuzix
Copy link
Contributor

liuzix commented Oct 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 365b4dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3166 (365b4dc) into master (3c3b915) will decrease coverage by 0.4024%.
The diff coverage is 50.8140%.

@@               Coverage Diff                @@
##             master      #3166        +/-   ##
================================================
- Coverage   57.2251%   56.8226%   -0.4025%     
================================================
  Files           163        210        +47     
  Lines         19453      22667      +3214     
================================================
+ Hits          11132      12880      +1748     
- Misses         7261       8471      +1210     
- Partials       1060       1316       +256     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3181.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3182.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3183.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3184.

@Rustin170506 Rustin170506 deleted the rustin-patch-tikv-log-rotation-size branch August 15, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants