Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm/openpai: add more task api #3171

Merged
merged 18 commits into from
Nov 1, 2021
Merged

dm/openpai: add more task api #3171

merged 18 commits into from
Nov 1, 2021

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

this is port of pingcap/dm#2222

What is changed and how it works?

as title, add more api about task

The api for the list table/schema is implemented by passing a json string using the Msg field in the rpc resp of the dm-worker.

close pingcap/dm#2222

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2021
@Ehco1996 Ehco1996 mentioned this pull request Oct 29, 2021
Closed
@Ehco1996
Copy link
Contributor Author

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor Author

/hold
need fix ci and some import path

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@Ehco1996
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@lance6716
Copy link
Contributor

/cc @okJiang @lichunzhu

okJiang
okJiang approved these changes Oct 29, 2021
View reviewed changes
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi.go Outdated Show resolved Hide resolved
dm/dm/master/openapi_test.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2021
@okJiang
Copy link
Member

okJiang commented Oct 29, 2021

I'm sorry I clicked the wrong button approve just now😂. Is there any way to revoke it?

okJiang
okJiang requested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revoke

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2021
@Ehco1996
Copy link
Contributor Author

I'm sorry I clicked the wrong button approve just now😂. Is there any way to revoke it?

you can remove the lgtm label, some file is wrong when I move pr from dm… i will fix this in next commit

@glorv glorv added the area/dm Issues or PRs related to DM. label Oct 29, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/hold

waiting for comments to be addressed

all comments are addressed, do you have more comments? @lance6716

@lance6716
Copy link
Contributor

/unhold
/run-dm-integration-tests

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2021
@glorv
Copy link
Contributor

glorv commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b57f23c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: be7cdbc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 1, 2021

/run-dm-integration-tests

@ti-chi-bot
Copy link
Member

@Ehco1996: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1ffa1bd into pingcap:master Nov 1, 2021
@Ehco1996 Ehco1996 mentioned this pull request Nov 4, 2021
Closed
@glorv glorv added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Nov 4, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 4, 2021
@Ehco1996 @ti-chi-bot
dm/openpai: add more task api (pingcap#3171)
0fc8540
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3263.

ti-chi-bot added a commit that referenced this pull request Nov 7, 2021
@ti-chi-bot
dm/openpai: add more task api (#3171) (#3263)
7dc044e
@Ehco1996 Ehco1996 deleted the dm-openapi-03-api branch December 20, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@lance6716 lance6716 lance6716 left review comments

@okJiang okJiang okJiang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ehco1996 @ti-chi-bot @lance6716 @okJiang @glorv @lichunzhu