Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: add retry in it full_mode test #3405

Closed
wants to merge 2 commits into from
Closed

dm: add retry in it full_mode test #3405

wants to merge 2 commits into from

Conversation

Ehco1996
Copy link
Contributor

@Ehco1996 Ehco1996 commented Nov 11, 2021

What problem does this PR solve?

as title, fix an unstable test

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

`None`.

@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Nov 11, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2021
@lance6716
Copy link
Contributor

if sync_diff works well, we should not need this change

https://github.com/pingcap/ticdc/pull/3413 PTAL

@Ehco1996
Copy link
Contributor Author

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2021
@Ehco1996 Ehco1996 deleted the dm-full-test branch December 20, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants