Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc): separate statistics for unit tests and integration tests #3570

Merged
merged 3 commits into from
Nov 22, 2021
Merged

test(ticdc): separate statistics for unit tests and integration tests #3570

merged 3 commits into from
Nov 22, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/3569

What is changed and how it works?

separate statistics for unit tests and integration tests.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2021
@Rustin170506
Copy link
Member Author

/run-copy

@Rustin170506
Copy link
Member Author

/run-copy

2 similar comments
@Rustin170506
Copy link
Member Author

/run-copy

@Rustin170506
Copy link
Member Author

/run-copy

@codecov-commenter
Copy link

Codecov Report

Merging #3570 (8f128c2) into master (24030f8) will increase coverage by 1.2971%.
The diff coverage is 68.8491%.

@@               Coverage Diff                @@
##             master      #3570        +/-   ##
================================================
+ Coverage   56.5356%   57.8328%   +1.2971%     
================================================
  Files           211        237        +26     
  Lines         22798      24142      +1344     
================================================
+ Hits          12889      13962      +1073     
- Misses         8598       8787       +189     
- Partials       1311       1393        +82

@Rustin170506
Copy link
Member Author

/cc @amyangfei @overvenus

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8f128c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@Rustin170506
Copy link
Member Author

/run-integration-test
/run-kafka-integration-test

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

3 similar comments
@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

😢

@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

😢 network issue

1 similar comment
@Rustin170506
Copy link
Member Author

/run-kafka-integration-test

😢 network issue

@ti-chi-bot ti-chi-bot merged commit 72de1b5 into pingcap:master Nov 22, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-unit-test branch November 22, 2021 09:41
@Rustin170506 Rustin170506 added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Nov 22, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3570
a1c2d0d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3570
c5731d8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3577.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3578.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3570
d19f72b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3579.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3570
5f52ec2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Nov 22, 2021
Merged
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3580.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3581.

overvenus pushed a commit that referenced this pull request Nov 23, 2021
@ti-chi-bot @Rustin170506
test(ticdc): separate statistics for unit tests and integration tests (…
ae7b015 
…#3570) (#3577)

* This is an automated cherry-pick of #3570

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* makefile: resolve conflicts

Co-authored-by: 0xC3 <rustin.liu@gmail.com>
ti-chi-bot added a commit that referenced this pull request Nov 23, 2021
@ti-chi-bot
test(ticdc): separate statistics for unit tests and integration tests (…
88f46a8 
…#3570) (#3579)
ti-chi-bot added a commit that referenced this pull request Nov 23, 2021
@ti-chi-bot
test(ticdc): separate statistics for unit tests and integration tests (…
ca987bc 
…#3570) (#3580)
ti-chi-bot added a commit that referenced this pull request Nov 23, 2021
@ti-chi-bot
test(ticdc): separate statistics for unit tests and integration tests (…
b23fd1d 
…#3570) (#3578)
Rustin170506 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 2, 2021
@Rustin170506
test(ticdc): separate statistics for unit tests and integration tests (…
c41e91c 
…pingcap#3570)
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@Rustin170506 @okJiang
test(ticdc): separate statistics for unit tests and integration tests (…
54ee6e3 
…pingcap#3570)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 25, 2021
@ti-chi-bot @3AceShowHand
test(ticdc): separate statistics for unit tests and integration tests (…
2913f7b 
…pingcap#3570) (pingcap#3579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rustin170506 @ti-chi-bot @codecov-commenter @amyangfei @3AceShowHand