Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: Sink manager manage checkpoint per table #3621

Merged
merged 23 commits into from
Nov 30, 2021
Merged

cdc/sink: Sink manager manage checkpoint per table #3621

merged 23 commits into from
Nov 30, 2021

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 25, 2021

What problem does this PR solve?

What is changed and how it works?

To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, sink manager manage checkpointTs per table

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2021
@sdojjy sdojjy mentioned this pull request Nov 26, 2021
Closed
9 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2021
@sdojjy sdojjy changed the title (WIP) cdc/sink: Sink manager manage checkpoint per table cdc/sink: Sink manager manage checkpoint per table Nov 26, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2021
overvenus
overvenus previously approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/sink/manager.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2021
@overvenus overvenus dismissed their stale review November 26, 2021 07:46

Will approve later.

@overvenus overvenus added the component/sink Sink component. label Nov 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #3621 (4008fce) into master (24030f8) will increase coverage by 1.5728%.
The diff coverage is 68.8811%.

@@               Coverage Diff                @@
##             master      #3621        +/-   ##
================================================
+ Coverage   56.5356%   58.1084%   +1.5728%     
================================================
  Files           211        241        +30     
  Lines         22798      24499      +1701     
================================================
+ Hits          12889      14236      +1347     
- Misses         8598       8842       +244     
- Partials       1311       1421       +110

@sdojjy
Copy link
Member Author

sdojjy commented Nov 26, 2021

/run-all-tests

overvenus
overvenus reviewed Nov 26, 2021
View reviewed changes
cdc/sink/manager.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2021
@amyangfei
Copy link
Contributor

Will these bug fixes be cherry-picked?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Nov 30, 2021

Will these bug fixes be cherry-picked?

no

@sdojjy
fix ut
2227e75
@sdojjy
Merge remote-tracking branch 'upstream/master' into sink-manager-mana…
e75d9d0 
…ge-checkpoint-per-table

# Conflicts:
#	cdc/processor/processor_test.go
@sdojjy
Copy link
Member Author

sdojjy commented Nov 30, 2021

/run-all-tests

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e75d9d0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 88984b5 into pingcap:master Nov 30, 2021
@sdojjy sdojjy deleted the sink-manager-manage-checkpoint-per-table branch November 30, 2021 14:59
@Rustin170506 Rustin170506 mentioned this pull request Dec 5, 2021
Closed
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@sdojjy @okJiang
cdc/sink: Sink manager manage checkpoint per table (pingcap#3621)
f37b88c
@sdojjy sdojjy restored the sink-manager-manage-checkpoint-per-table branch December 27, 2021 02:55
@sdojjy sdojjy mentioned this pull request Dec 27, 2021
Merged
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sdojjy @ti-chi-bot @codecov-commenter @amyangfei @overvenus @asddongmen