Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) #3862

Merged
merged 4 commits into from
Jan 12, 2022
Merged

owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) #3862

merged 4 commits into from
Jan 12, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 13, 2021 •
edited by Rustin170506
Loading

This is an automated cherry-pick of #3838 and #3917

What problem does this PR solve?

close #3473

close https://github.com/pingcap/ticdc/pull/3553

What is changed and how it works?

Add bootstrap and try to fix the meta information in it.
Introduce creator version gate. We will determine if this information needs to be updated based on the version of the new owner introduced.

Check List

Tests

Code changes

  • Has exported function/method change

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix the issue of changefeed resuming automatically after upgrading cluster

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved area/ticdc Issues or PRs related to TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 13, 2021
Merged
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Dec 13, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2021
@overvenus overvenus added this to the v5.0.7 milestone Jan 11, 2022
@Rustin170506 Rustin170506 force-pushed the cherry-pick-3838-to-release-5.0 branch from 6011afa to 5e80ad6 Compare January 12, 2022 07:54
Rustin170506
Rustin170506 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

@Rustin170506 Rustin170506 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1d2c158

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d1d1372

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@Rustin170506
Copy link
Member

/run-leak-test

@Rustin170506
Copy link
Member

/run-unit-test

@nongfushanquan nongfushanquan added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 12, 2022
@Rustin170506
Copy link
Member

/run-unit-test

2 similar comments
@Rustin170506
Copy link
Member

/run-unit-test

@Rustin170506
Copy link
Member

/run-unit-test

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-kafka-integration-test

2 similar comments
@Rustin170506
Copy link
Member

/run-kafka-integration-test

@Rustin170506
Copy link
Member

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit e572735 into pingcap:release-5.0 Jan 12, 2022
Rustin170506 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 14, 2022
@ti-chi-bot @Rustin170506
owner(ticdc): Add bootstrap and try to fix the meta information in it (…
00a0ce3 
…pingcap#3838) (pingcap#3862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees

@Rustin170506 Rustin170506

Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @Rustin170506 @overvenus @nongfushanquan