-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): asynchronously create sink (#3598) #3961
owner(ticdc): asynchronously create sink (#3598) #3961
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
hold this one to be merged, after asynchronous sink initialization and close if fully merged and test. |
Codecov Report
@@ Coverage Diff @@
## release-5.1 #3961 +/- ##
================================================
Coverage ? 57.6743%
================================================
Files ? 166
Lines ? 19513
Branches ? 0
================================================
Hits ? 11254
Misses ? 7204
Partials ? 1055 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cb70186
|
This is an automated cherry-pick of #3598
What problem does this PR solve?
close #3352
What is changed and how it works?
AsyncSink
toDDLSink
. We should care more about the usage when naming variables, but not the way how it works.DDLSink
Check List
Tests
Code changes
Side effects
Related changes
Release note