-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc/owner: Fix ddl special comment syntax error (#3845) #3979
ticdc/owner: Fix ddl special comment syntax error (#3845) #3979
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…efactor # Conflicts: # cdc/processor/pipeline/sink.go
…3845-to-release-4.0 # Conflicts: # go.sum
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
This is an automated cherry-pick of #3845
What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/3755
What is changed and how it works?
not use regex to parse and add special TiDB comments, If a DDL already has special comment like
/*!90000 SHARD_ROW_ID_BITS=4 PRE_SPLIT_REGIONS=3 */
, it wil translate that DDL to/*!90000 /*T! SHARD_ROW_ID_BITS=4 PRE_SPLIT_REGIONS=3 */ */
, TiDB will throw a syntax error.this PR use the TiDB SQL parser to parse the SQL and the Restore it with
format.RestoreStringSingleQuotes|format.RestoreNameBackQuotes|format.RestoreKeyWordUppercase|format.RestoreTiDBSpecialComment
flagCheck List
Tests
Code changes
Side effects
Related changes
Release note