Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner, processor(cdc): fix reporting ErrPeerMessageClientClosed to user erroneously #3980

Merged
merged 7 commits into from
Dec 21, 2021
Merged

owner, processor(cdc): fix reporting ErrPeerMessageClientClosed to user erroneously #3980

merged 7 commits into from
Dec 21, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Dec 20, 2021

This is a bug fix on unreleased code.

What problem does this PR solve?

Close #3972

  • This error should not be directly reported to the user since it may not represent an actual failure.

What is changed and how it works?

  • Do not report ErrPeerMessageClientClosed

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 20, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2021
@liuzix liuzix requested review from asddongmen and ben1009 December 20, 2021 06:30
@liuzix liuzix added area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. labels Dec 20, 2021
@liuzix liuzix added this to the v5.4.0 milestone Dec 20, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-leak-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-leak-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-verify

@asddongmen asddongmen mentioned this pull request Dec 20, 2021
Closed
@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0d227cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-integration-tests

@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-kafka-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-integration-tests

@liuzix
Copy link
Contributor Author

liuzix commented Dec 20, 2021

/run-kafka-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented Dec 21, 2021

/run-integration-tests

@liuzix
Copy link
Contributor Author

liuzix commented Dec 21, 2021

/run-kafka-integration-test

@liuzix
Copy link
Contributor Author

liuzix commented Dec 21, 2021

/run-kafka-integration-test /tidb=pr/30773
/run-integration-tests /tidb=pr/30773
/run-leak-test

@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liuzix
Copy link
Contributor Author

liuzix commented Dec 21, 2021

/run-integration-tests /tidb=pr/30773

@liuzix
Copy link
Contributor Author

liuzix commented Dec 21, 2021

/run-integration-tests

@overvenus overvenus merged commit 68db903 into pingcap:master Dec 21, 2021
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@liuzix @ti-chi-bot @zhaoxinyu
owner, processor(cdc): fix reporting ErrPeerMessageClientClosed to us…
f8b4298 
…er erroneously (pingcap#3980)

* owner, processor(cdc): fix reporting ErrPeerMessageClientClosed to user erroneously

* p2p/client: fix unstable test

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

@ben1009 ben1009 Awaiting requested review from ben1009

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

[CC scenario] CDC:ErrPeerMessageClientClosed
4 participants
@liuzix @ti-chi-bot @overvenus @asddongmen