config(ticdc): force enable old value for canal json protocol

[Rustin170506]

What problem does this PR solve?

We should turn on the old value for canal json when we create the changefeed.
close #3676

What is changed and how it works?

force enable old value for canal json protocol

Check List

Tests

• Unit test
• Manual test (See: config(ticdc): force enable old value for canal json protocol #3983 (comment))

Code changes

• Has exported function/method change
• Has exported variable/fields change

Side effects

None

Related changes

• Need to cherry-pick to the release branch(I will do it manually.)
• Need to update the documentation ticdc: Use open-protocol instead of default protocol and add missing params docs-cn#8047

Release note

Fix the problem that old value is not forced on automatically in Canal JSON protocol

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• asddongmen
• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Rustin170506]

Manual test procedure.

1. Start the tidb cluster
2. start kafka into the cluster
3. start ticdc server
4. Create a changefeed with the following command: . /cdc cli changefeed create --pd http://127.0.0.1:2379 --sink-uri "kafka://127.0.0.1:9092/ticdc-test2" --config=changefeed.toml

enable-old-value=false

[sink]
protocol="canal-json"

5. check the log

[2021/12/20 14:49:25.418 +08:00] [WARN] [cli_changefeed_create.go:207] ["Attempting to replicate without old value enabled. CDC will enable old value and continue."] [protocol=canal-json]

[Rustin170506]

/cc @maxshuang @asddongmen

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

[Rustin170506]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 4aa46db

[Rustin170506]

/run-dm-integration-test

[lance6716]

/run-dm-integration-test

[Rustin170506]

/run-dm-integration-test

[ti-chi-bot]

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Rustin170506]

/run-all-tests

[Rustin170506]

/run-kafka-integration-test
/run-verify

[Rustin170506]

/run-verify

[codecov-commenter]

Codecov Report

Merging #3983 (d80eae2) into master (3873d39) will decrease coverage by 1.8349%.
The diff coverage is 68.1818%.

Flag	Coverage Δ
cdc	58.7358% <68.1818%> (+0.4992%)	⬆️
dm	52.3014% <ø> (-3.7332%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3983        +/-   ##
================================================
- Coverage   57.0741%   55.2391%   -1.8350%     
================================================
  Files           478        484         +6     
  Lines         56551      59809      +3258     
================================================
+ Hits          32276      33038       +762     
- Misses        20978      23425      +2447     
- Partials       3297       3346        +49