-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): set max-message-bytes default to 10m (#4036) #4059
sink(ticdc): set max-message-bytes default to 10m (#4036) #4059
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #4059 +/- ##
===================================================
+ Coverage 53.7661% 61.8996% +8.1335%
===================================================
Files 153 162 +9
Lines 15958 16782 +824
===================================================
+ Hits 8580 10388 +1808
+ Misses 6475 5501 -974
+ Partials 903 893 -10 |
/run-all-tests |
/run-unit-test |
1 similar comment
/run-unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 674b635
|
/run-integration-test |
This is an automated cherry-pick of #4036
What problem does this PR solve?
close #4041
set Kafka producer's default
max-message-bytes
to 10M, and use the minimum value among sink-uri'smax-message-bytes
, broker'smessage.max.bytes
, topic'smax.message.bytes
to initialize the producer.What is changed and how it works?
max-message-bytes
to 10MCheck List
Tests
Code changes
Side effects
Related changes
Release note