Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): set max-message-bytes default to 10m (#4036) #4062

Merged
merged 8 commits into from
Feb 8, 2022
Merged

sink(ticdc): set max-message-bytes default to 10m (#4036) #4062

merged 8 commits into from
Feb 8, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4036

What problem does this PR solve?

close #4041
set Kafka producer's default max-message-bytes to 10M, and use the minimum value among sink-uri's max-message-bytes, broker's message.max.bytes, topic's max.message.bytes to initialize the producer.

What is changed and how it works?

  • set the default value of max-message-bytes to 10M
  • use the min value of the 3 mentioned above to initialize the producer.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

Set `max-message-bytes` default to 10M, and use the min value with topic and broker to initialize the producer.

@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4036
807c040 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 24, 2021
Merged
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Dec 24, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2021
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4074
42dc87b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@overvenus overvenus added this to the v5.2.4 milestone Jan 6, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2022
@3AceShowHand 3AceShowHand mentioned this pull request Jan 24, 2022
Closed
@3AceShowHand
Copy link
Contributor

/run-all-tests

@Rustin170506 Rustin170506 mentioned this pull request Feb 8, 2022
Merged
@3AceShowHand
Copy link
Contributor

/run-all-tests

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 8, 2022
@overvenus overvenus added the component/sink Sink component. label Feb 8, 2022
@3AceShowHand
Copy link
Contributor

/run-all-tests

@Rustin170506 Rustin170506 mentioned this pull request Feb 8, 2022
Merged
11 tasks
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 344431b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2022
@3AceShowHand
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 3522f86 into pingcap:release-5.2 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3AceShowHand 3AceShowHand

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @3AceShowHand @Rustin170506 @overvenus @VelocityLight