Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ticdc): add tests for kafka max-message-bytes #4125

Merged
merged 5 commits into from
Dec 30, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: close #4124

What is changed and how it works?

add tests for kafka max-message-bytes

  • When Topic exists
  • When Topic does not exist

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • ben1009

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506 Rustin170506 added the area/ticdc Issues or PRs related to TiCDC. label Dec 29, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-all-tests

Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check.

@Rustin170506 Rustin170506 added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Dec 29, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2021
@ben1009
Copy link
Contributor

ben1009 commented Dec 30, 2021

[2021-12-29T14:55:20.670Z] panic:

[2021-12-29T14:55:20.670Z] assert: mock: I don't know what to return because the method call was unexpected.

[2021-12-29T14:55:20.670Z] Either do Mock.On("Flush").Return(...) first, or remove the Flush() call.

[2021-12-29T14:55:20.670Z] This method was unexpected:

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 30, 2021
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0d6eff4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #4125 (32f52ce) into master (08da001) will increase coverage by 0.1720%.
The diff coverage is 66.1840%.

Flag Coverage Δ
cdc 58.8676% <67.8571%> (+0.2228%) ⬆️
dm 52.3342% <60.1895%> (+0.0797%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4125        +/-   ##
================================================
+ Coverage   55.1722%   55.3442%   +0.1720%     
================================================
  Files           485        489         +4     
  Lines         59829      60532       +703     
================================================
+ Hits          33009      33501       +492     
- Misses        23484      23670       +186     
- Partials       3336       3361        +25     

@ti-chi-bot ti-chi-bot merged commit b581f78 into pingcap:master Dec 30, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4153.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4154.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4155.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4156.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for kafka max-message-bytes param
6 participants