Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This adds support for writing to multiple kafka topics
Issue Number: ref #1147
What is changed and how it works?
By default the static topic name specified in the URL is used. But tables are registered in the registry by
{schema}_{table}
.In #3936 support is added to set the name in the registry to match the topic name. The benefits of this are:
This PR does set the topic name dynamically to
{topic_from_url}_{schema}_{table}
. This makes this easier to setup and maintain.Unsolved issues / TODO:
{topic_from_url}_{schema}_{table}
as the current{schema}_{table}
naming doesn't match. The prefix is needed in case multiple unrelated schema/table combinations are used with unrelated CDC instances but the same kafka broker.NumPartitions: 3
andReplicationFactor: 1
MaxMessageBytes
etc. for the topics. Maybe re-unify this withvalidateMaxMessageBytesAndCreateTopic
Check List
Tests
Code changes
Side effects
Related changes
Release note