Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): adjust sql mode compatibility for mysql sink (#3938) #4195

Closed
wants to merge 1 commit into from
Closed

sink(ticdc): adjust sql mode compatibility for mysql sink (#3938) #4195

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3938

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

Close #3810.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

None

@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#3938
6d14a75 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2022
Merged
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Jan 3, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2022
@overvenus overvenus added this to the v5.2.4 milestone Jan 6, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 23, 2022
@hicqu hicqu removed cherry-pick-approved Cherry pick PR approved by release team. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Apr 15, 2022
@hicqu
Copy link
Contributor

hicqu commented Apr 15, 2022

This PR depends on package tiflow/dm, which is not available for 5.2. We can close it.

@hicqu hicqu closed this Apr 15, 2022
@hicqu hicqu removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hicqu hicqu

Labels
cherry-pick-approved Cherry pick PR approved by release team. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @hicqu @overvenus @VelocityLight