Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): adjust sql mode compatibility for mysql sink (#3938) #4197

Merged
merged 2 commits into from
Jan 4, 2022
Merged

sink(ticdc): adjust sql mode compatibility for mysql sink (#3938) #4197

merged 2 commits into from
Jan 4, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3938

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

Close #3810.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2022
Merged
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jan 3, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 4, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: fd0ccc1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2022
@overvenus overvenus added this to the v5.4.0 milestone Jan 4, 2022
@overvenus
Copy link
Member

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 1812a71 into pingcap:release-5.4 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hicqu hicqu

Labels
cherry-pick-approved Cherry pick PR approved by release team. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @overvenus @hicqu @VelocityLight