-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4339
owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4339
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@zhaoxinyu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0a38b87
|
/merge |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #4262
What problem does this PR solve?
Issue Number: close #3329 close #3987
What is changed and how it works?
Before this optimization:
When errors occurred in a changefeed, a simple backoff is leveraged to restart a changefeed:
If there are three errors which occurred in two minutes, the changefeed stays in "error" state and won't be restarted imediately.
After this optimization:
We utilize an exponential backoff mechanism in the changefeed restart logic. The mechanism is elaborated as follows:
InitialInterval
to aMaxInterval
. And if the duration since backoff start exceed theMaxElapsedTime
, the changefeed will be switched to "failed" state and will not be restarted until it is manually resumed.InitialInterval
.Check List
Tests
Release note