Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4339

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4262

What problem does this PR solve?

Issue Number: close #3329 close #3987

What is changed and how it works?

Before this optimization:
When errors occurred in a changefeed, a simple backoff is leveraged to restart a changefeed:
If there are three errors which occurred in two minutes, the changefeed stays in "error" state and won't be restarted imediately.

After this optimization:
We utilize an exponential backoff mechanism in the changefeed restart logic. The mechanism is elaborated as follows:

  1. When we need to restart a changefeed in "error" state, the restart interval is varying from an InitialInterval to a MaxInterval. And if the duration since backoff start exceed the MaxElapsedTime, the changefeed will be switched to "failed" state and will not be restarted until it is manually resumed.
  2. If the changefeed was running normally in a period of time and it encounters error at present, we can reset the backoff and let the restart interval vary from the InitialInterval.

Check List

Tests

  • Unit test
  • Integration test

Release note

Add exponential backoff mechanism for restarting a changefeed.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added area/ticdc Issues or PRs related to TiCDC. component/owner Owner component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Jan 14, 2022
@overvenus overvenus added this to the v5.3.1 milestone Jan 17, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2022
@zhaoxinyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@zhaoxinyu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0a38b87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9d50aba into pingcap:release-5.3 Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/owner Owner component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants