Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui(dm): always redircet to index page #4350

Merged
merged 4 commits into from
Jan 27, 2022
Merged

webui(dm): always redircet to index page #4350

merged 4 commits into from
Jan 27, 2022

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #3583

What is changed and how it works?

as title

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • start a dm-master with ui and access some page like "/dashboard/xxxxx", you should got a redircet to /dashboard/

Code changes

Side effects

  • Possible performance regression

Related changes

Release note 

`None`.

@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Jan 17, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2022
@Ehco1996 Ehco1996 mentioned this pull request Jan 17, 2022
Closed
14 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #4350 (a840fdb) into master (ab62e6b) will decrease coverage by 0.1479%.
The diff coverage is 44.0955%.

Flag Coverage Δ
cdc 59.2864% <56.0330%> (-0.3295%) ⬇️
dm 52.0859% <35.6976%> (+0.0203%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4350        +/-   ##
================================================
- Coverage   55.5183%   55.3703%   -0.1480%     
================================================
  Files           495        495                
  Lines         61151      61262       +111     
================================================
- Hits          33950      33921        -29     
- Misses        23789      23942       +153     
+ Partials       3412       3399        -13

@Ehco1996
Copy link
Contributor Author

could you please take another look for this pr ? thanks 🧡🧡🧡
/cc @D3Hunter @okJiang

D3Hunter
D3Hunter approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/ui/server.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@Ehco1996 @D3Hunter
Update dm/ui/server.go
5ec9183 
Co-authored-by: D3Hunter <jujj603@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 27, 2022
@Ehco1996
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5ec9183

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@Ehco1996
Copy link
Contributor Author

/merge

@Ehco1996 Ehco1996 closed this Jan 27, 2022
@Ehco1996 Ehco1996 reopened this Jan 27, 2022
@Ehco1996
Copy link
Contributor Author

ping license/cla 😷😷

@ti-chi-bot ti-chi-bot merged commit 757decd into pingcap:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

@okJiang okJiang Awaiting requested review from okJiang

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ehco1996 @ti-chi-bot @codecov-commenter @lance6716 @D3Hunter