Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(cdc): fix data race in TestMessageClientBasics #4417

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jan 19, 2022

What problem does this PR solve?

Issue Number: ref #3825

What is changed and how it works?

  • Made mockSendMessageClient thread-safe.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@liuzix liuzix added component/test Unit tests and integration tests component. area/ticdc Issues or PRs related to TiCDC. labels Jan 19, 2022
@liuzix liuzix requested review from amyangfei and overvenus January 19, 2022 16:00
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2022
@3AceShowHand
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2022
@amyangfei amyangfei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9e7dfe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Jan 20, 2022

/run-integration-tests

@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/run-integration-tests /tidb=pr/30558
/run-kafka-integration-test /tidb=pr/30558

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants