kv-client: ignore commit log without prewrite before initialized #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
================================================
- Coverage 29.2417% 29.1483% -0.0934%
================================================
Files 59 58 -1
Lines 5328 5695 +367
================================================
+ Hits 1558 1660 +102
- Misses 3629 3923 +294
+ Partials 141 112 -29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the incremental scan procedure, TiKV may send commit event without a corresponding prewrite event.
What is changed and how it works?
We can just ignore this commit event, but don't check whether the committed log with same
start-tsandkeyis really received, because the check may cost too much memory to storestart-ts-keypair of all committed events.Check List
Tests