Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): add async checkpoint flush integration test #4538

Merged
merged 7 commits into from
Mar 8, 2022

Conversation

db-will
Copy link
Contributor

@db-will db-will commented Feb 9, 2022

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

Add integration test for async checkpoint flush to simulate failure of async flush

Check List

Tests

  • Integration test

Code changes
None

Side effects
None

Related changes

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 9, 2022
@db-will db-will requested a review from glorv February 9, 2022 03:50
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2022
@db-will db-will requested a review from lance6716 February 9, 2022 03:50
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Feb 9, 2022
@db-will
Copy link
Contributor Author

db-will commented Feb 9, 2022

/run-integration-test

@lance6716 lance6716 changed the title Add async checkpoint flush integration test test(dm): add async checkpoint flush integration test Feb 10, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2022
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Feb 10, 2022

Do you have time to look at this issue #3928? I think it may be introduced by async checkpoint

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added integration tests should put its name in dm/tests/others_integration_1.txt or others_integration_2.txt

BTW, what's the detailed scenario this test want to imitate? Failed to async flush checkpoint will not block data replication?

@lance6716
Copy link
Contributor

ping @db-will

@db-will
Copy link
Contributor Author

db-will commented Mar 3, 2022

yes, cause we don't want to background async flush failure could impact on DM process.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #4538 (5ea0ab8) into master (9607554) will increase coverage by 0.1513%.
The diff coverage is 54.6845%.

Flag Coverage Δ
cdc 59.9740% <54.6845%> (+0.0518%) ⬆️
dm 52.3327% <ø> (+0.3038%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4538        +/-   ##
================================================
+ Coverage   55.6402%   55.7915%   +0.1513%     
================================================
  Files           494        521        +27     
  Lines         61283      64732      +3449     
================================================
+ Hits          34098      36115      +2017     
- Misses        23750      25094      +1344     
- Partials       3435       3523        +88     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@db-will db-will requested a review from GMHDBJD March 7, 2022 23:10
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ehco1996
Copy link
Contributor

Ehco1996 commented Mar 8, 2022

/run-dm-integration-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dbcf9eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 3466eaf into pingcap:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants