-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(dm): add async checkpoint flush integration test #4538
test(dm): add async checkpoint flush integration test #4538
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-integration-test |
Do you have time to look at this issue #3928? I think it may be introduced by async checkpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added integration tests should put its name in dm/tests/others_integration_1.txt
or others_integration_2.txt
BTW, what's the detailed scenario this test want to imitate? Failed to async flush checkpoint will not block data replication?
ping @db-will |
yes, cause we don't want to background async flush failure could impact on DM process. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4538 +/- ##
================================================
+ Coverage 55.6402% 55.7915% +0.1513%
================================================
Files 494 521 +27
Lines 61283 64732 +3449
================================================
+ Hits 34098 36115 +2017
- Misses 23750 25094 +1344
- Partials 3435 3523 +88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-dm-integration-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: dbcf9eb
|
/merge |
What problem does this PR solve?
Issue Number: ref #4159
What is changed and how it works?
Add integration test for async checkpoint flush to simulate failure of async flush
Check List
Tests
Code changes
None
Side effects
None
Related changes
Release note