Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): fix Unknown system variable 'transaction_isolation' for some mysql versions #4569

Merged
merged 12 commits into from
Feb 14, 2022
Merged

sink(ticdc): fix Unknown system variable 'transaction_isolation' for some mysql versions #4569

merged 12 commits into from
Feb 14, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4504

What is changed and how it works?

Since MySQL 5.7/MySQL 8/Mariadb may use transaction_isolation or tx_isolation, we first select the variable and use the right variable after that.

Check List

Tests

  • Unit test

Release note 

fix `Unknown system variable 'transaction_isolation'` for some mysql versions

@maxshuang maxshuang requested a review from amyangfei February 11, 2022 10:33
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 11, 2022
@maxshuang maxshuang requested a review from zhaoxinyu February 11, 2022 10:33
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2022
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang maxshuang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2022
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang maxshuang changed the title sink(tiflow): fix Unknown system variable 'transaction_isolation' for some mysql versions sink(ticdc): fix Unknown system variable 'transaction_isolation' for some mysql versions Feb 14, 2022
@zhaoxinyu
Copy link
Contributor

test case TestApplyDMLs failed. PTAL @maxshuang

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2022
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

test case TestApplyDMLs failed. PTAL @maxshuang

Thanks for reminding. I have fixed it.

@codecov-commenter
Copy link

Codecov Report

Merging #4569 (718aedf) into master (9607554) will increase coverage by 0.0174%.
The diff coverage is 62.2743%.

Flag Coverage Δ
cdc 60.4294% <60.0000%> (+0.5071%) ⬆️
dm 51.5610% <63.1317%> (-0.4679%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4569        +/-   ##
================================================
+ Coverage   55.6402%   55.6577%   +0.0174%     
================================================
  Files           494        503         +9     
  Lines         61283      62207       +924     
================================================
+ Hits          34098      34623       +525     
- Misses        23750      24125       +375     
- Partials       3435       3459        +24

@ti-chi-bot
Copy link
Member

@zhaoxinyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@maxshuang maxshuang requested a review from liuzix February 14, 2022 06:21
@maxshuang maxshuang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@maxshuang maxshuang requested a review from overvenus February 14, 2022 06:23
@maxshuang maxshuang requested review from lance6716 and removed request for overvenus and liuzix February 14, 2022 06:27
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2022
@maxshuang maxshuang requested a review from overvenus February 14, 2022 06:36
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 718aedf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@maxshuang
Copy link
Contributor Author

/run-leak-test
/run-unit-test

@maxshuang
Copy link
Contributor Author

/run-unit-test

@maxshuang
Copy link
Contributor Author

/run-verify

@maxshuang
Copy link
Contributor Author

/run-leak-test

@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-dm-integration-test

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test

@maxshuang
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 67a3029 into pingcap:master Feb 14, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@zhaoxinyu
sink(ticdc): fix Unknown system variable 'transaction_isolation' fo…
e8897e3 
…r some mysql versions (pingcap#4569)

close pingcap#4504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@lance6716 lance6716 lance6716 approved these changes

@amyangfei amyangfei amyangfei approved these changes

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sink to mariadb 10.6.5 fails with unknown system variable transaction_isolation
7 participants
@maxshuang @ti-chi-bot @zhaoxinyu @codecov-commenter @amyangfei @lance6716 @okJiang