-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracker(dm): respect CHARSET when build TableInfo (#4638) #4645
tracker(dm): respect CHARSET when build TableInfo (#4638) #4645
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-5.3 #4645 +/- ##
================================================
Coverage ? 55.5001%
================================================
Files ? 221
Lines ? 23654
Branches ? 0
================================================
Hits ? 13128
Misses ? 9217
Partials ? 1309 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 53b5978
|
/run-unit-test |
/merge |
/hold found an extra processing is missing |
/unhold |
/run-dm-integration-test |
This is an automated cherry-pick of #4638
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #4637
What is changed and how it works?
found that MockTableInfo will always use default charset and collation, BuildTableInfoFromAST is better
Check List
Tests
Code changes
Side effects
Related changes
Release note