Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix the issue about getting the wrong schema snap when start changefeed #478

Merged
merged 15 commits into from
Apr 21, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Apr 21, 2020

What problem does this PR solve?

  • fix the issue about getting the wrong schema snap when start changefeed
  • add a PrintStatus function for schema snap to make debug easier, and print the status of schema snap when some error happened.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one changed the title schema: fix a bug about create table in schema storage owner: fix the issue about getting the wrong schema snap when start changefeed Apr 21, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-io
Copy link

Codecov Report

Merging #478 into master will increase coverage by 0.2228%.
The diff coverage is 22.0370%.

@@               Coverage Diff                @@
##             master       #478        +/-   ##
================================================
+ Coverage   29.0322%   29.2551%   +0.2228%     
================================================
  Files            58         58                
  Lines          5673       5934       +261     
================================================
+ Hits           1647       1736        +89     
- Misses         3913       4080       +167     
- Partials        113        118         +5     

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the LGT1 label Apr 21, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one merged commit a604f1b into pingcap:master Apr 21, 2020
@zier-one zier-one deleted the fix_schema branch May 11, 2020 02:29
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants