owner: fix global checkpointts stopping when it 's not exist changefees #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
zier-one
changed the title
amyangfei
reviewed
Apr 26, 2020
cdc/changefeed.go
Outdated
Comment on lines
483
to
486
| if len(c.taskPositions) == 0 { | ||
| minCheckpointTs = c.status.CheckpointTs | ||
| minCheckpointTs = c.status.ResolvedTs | ||
| } else if len(c.taskPositions) < len(c.taskStatus) { | ||
| return nil |
There was a problem hiding this comment.
Is this better:
- check if
len(c.taskPositions) < len(c.taskStatus), do nothing - then check if
len(c.taskPositions) == 0, updateminCheckpointTstoc.status.ResolvedTs
If owner has dispatched a table but processor doesn't start replicating it, owner should wait until the processor is ready?
There was a problem hiding this comment.
If owner has dispatched a table but processor doesn't start replicating it, owner should wait until the processor is ready?
Yes, the owner should, and we using table lock to make the owner wait until the processor is ready now
|
/run-all-tests |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
===========================================
Coverage 26.2199% 26.2199%
===========================================
Files 61 61
Lines 6373 6373
===========================================
Hits 1671 1671
Misses 4589 4589
Partials 113 113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If the number of changefeed is zero, checkpoint will not be pushing
What is changed and how it works?
Check List
Tests