Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task_checker(dm): refactor and expose an auto resume function #5004

Merged
merged 5 commits into from
Mar 25, 2022
Merged

task_checker(dm): refactor and expose an auto resume function #5004

merged 5 commits into from
Mar 25, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

as title. For dataflow engine, an unit can be checked auto resume by build an AutoResumeTimes and UpdateResumeStrategy

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

Release note 

`None`.

@lance6716
task_checker(dm): refact and expose an auto resume function
3a3ba31 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • Ehco1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 23, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Mar 23, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 23, 2022
@lance6716
Copy link
Contributor Author

/run-verify
/run-leak-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-leak-test

D3Hunter
D3Hunter reviewed Mar 24, 2022
View reviewed changes
dm/dm/worker/task_checker.go Outdated Show resolved Hide resolved
dm/dm/worker/task_checker.go Outdated Show resolved Hide resolved
@lance6716
address comment
7dd99f8 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #5004 (be73e9e) into master (687e248) will decrease coverage by 0.2686%.
The diff coverage is 52.0814%.

Flag Coverage Δ
cdc 61.1913% <44.4565%> (+0.5927%) ⬆️
dm 51.5698% <85.6459%> (-0.8997%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5004        +/-   ##
================================================
- Coverage   56.1240%   55.8553%   -0.2687%     
================================================
  Files           522        523         +1     
  Lines         65325      66674      +1349     
================================================
+ Hits          36663      37241       +578     
- Misses        25094      25755       +661     
- Partials       3568       3678       +110

Ehco1996
Ehco1996 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7dd99f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Mar 25, 2022

Can we make AutoResumeInfo as a default interface, and TaskAutoResume/RelayAutoResume implement the CheckResume and Resume func? just like the template method pattern

@lance6716
Copy link
Contributor Author

Can we make AutoResumeInfo as a default interface, and TaskAutoResume/RelayAutoResume implement the CheckResume and Resume func? just like the template method pattern

left for future work🙈

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 69d6328 into pingcap:master Mar 25, 2022
lance6716 added a commit that referenced this pull request Mar 28, 2022
@lance6716
task_checker(dm): refactor and expose an auto resume function (#5004)
bddf162 
ref #4287
@lance6716 lance6716 deleted the refine-checker branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lance6716 @ti-chi-bot @codecov-commenter @GMHDBJD @D3Hunter @Ehco1996