Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay(dm): send one heartbeat for successive skipped GTID (#5070) #5094

Closed
wants to merge 4 commits into from
Closed

relay(dm): send one heartbeat for successive skipped GTID (#5070) #5094

wants to merge 4 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5070

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #5063

What is changed and how it works?

see #5063 (comment)

Check List

Tests

  • Integration test
  • Unit tests

Related changes

  • Need to cherry-pick to the release branch

Release note 

send one heartbeat for successive skipped GTID when enable relay log

@lance6716 @ti-chi-bot
relay(dm): send one heartbeat for successive skipped GTID
7fcc088 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix CI
7bf5443 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix again
1d077a5 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
address comment
7fb9105 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR. labels Apr 1, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7fb9105

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@lance6716
Copy link
Contributor

/hold

wait 6.0 release

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@lance6716
Copy link
Contributor

seems we don't need to fix bugs for 6.0

@lance6716 lance6716 closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lance6716 lance6716

Labels
area/dm Issues or PRs related to DM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @lance6716