Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream (ticdc): add upstream to manage all upstream related resources. #5282

Merged
merged 32 commits into from
May 5, 2022
Merged

upstream (ticdc): add upstream to manage all upstream related resources. #5282

merged 32 commits into from
May 5, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Apr 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5288

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 26, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2022
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen asddongmen added the status/ptal Could you please take a look? label Apr 27, 2022
@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

@asddongmen
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022 •
edited
Loading

Codecov Report

Merging #5282 (fcc902b) into master (687e248) will decrease coverage by 0.0296%.
The diff coverage is 53.3055%.

Flag Coverage Δ
cdc 61.0342% <53.3055%> (+0.4355%) ⬆️
dm 52.2128% <ø> (-0.2567%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5282        +/-   ##
================================================
- Coverage   56.1240%   56.0943%   -0.0297%     
================================================
  Files           522        527         +5     
  Lines         65325      68957      +3632     
================================================
+ Hits          36663      38681      +2018     
- Misses        25094      26546      +1452     
- Partials       3568       3730       +162

liuzix
liuzix reviewed Apr 27, 2022
View reviewed changes
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/upstream.go Show resolved Hide resolved
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/manager.go Outdated Show resolved Hide resolved
pkg/upstream/upstream.go Outdated Show resolved Hide resolved
pkg/upstream/upstream.go Outdated Show resolved Hide resolved
sdojjy
sdojjy reviewed Apr 27, 2022
View reviewed changes
pkg/upstream/manager.go Outdated Show resolved Hide resolved
sdojjy
sdojjy reviewed Apr 27, 2022
View reviewed changes
cdc/owner/owner.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7668ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4122dc4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff2435b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@asddongmen
Copy link
Contributor Author

/run-verify
/run-dm-integration-tests

@asddongmen
Copy link
Contributor Author

/run-leak-tests

1 similar comment
@asddongmen
Copy link
Contributor Author

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit 9bcebc1 into pingcap:master May 5, 2022
@asddongmen asddongmen deleted the add_upstream branch July 21, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@sdojjy sdojjy sdojjy approved these changes

@overvenus overvenus Awaiting requested review from overvenus

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upstream to manager all upstream related resources.
7 participants
@asddongmen @ti-chi-bot @codecov-commenter @sdojjy @liuzix @CharlesCheung96 @nongfushanquan