Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM/Openapi: improve password input mechanism source #5369

Merged
merged 17 commits into from
May 13, 2022
Merged

DM/Openapi: improve password input mechanism source #5369

merged 17 commits into from
May 13, 2022

Conversation

WizardXiao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #4986

What is changed and how it works?

source's password can be nil.

  1. password will be set "" when create source with password which is nil.
  2. password will use old password when update source with password which is nil.

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • Ehco1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@WizardXiao WizardXiao added area/dm Issues or PRs related to DM. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2022
@WizardXiao
Copy link
Contributor Author

/cc @Ehco1996

@ti-chi-bot ti-chi-bot requested a review from Ehco1996 May 10, 2022 03:52
D3Hunter
D3Hunter reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/dm/config/source_converter.go Outdated Show resolved Hide resolved
dm/dm/master/openapi_controller.go Outdated Show resolved Hide resolved
Ehco1996
Ehco1996 reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restLGTM

dm/openapi/spec/dm.yaml Show resolved Hide resolved
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-leak-test

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2022
Ehco1996
Ehco1996 approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2022
@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@WizardXiao
Copy link
Contributor Author

/run-verify-ci

@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #5369 (ea62b22) into master (687e248) will decrease coverage by 0.1122%.
The diff coverage is 51.8056%.

Flag Coverage Δ
cdc 61.0290% <51.8056%> (+0.4304%) ⬆️
dm 52.1079% <ø> (-0.3617%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5369        +/-   ##
================================================
- Coverage   56.1240%   56.0117%   -0.1123%     
================================================
  Files           522        529         +7     
  Lines         65325      69464      +4139     
================================================
+ Hits          36663      38908      +2245     
- Misses        25094      26843      +1749     
- Partials       3568       3713       +145

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-leak-test

@WizardXiao
Copy link
Contributor Author

/run-integration-test

@WizardXiao
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@WizardXiao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WizardXiao
Copy link
Contributor Author

/run-verify-ci
/run-leak-test
/run-kafka-integration-test
/run-integration-test
/run-dm-integration-test
/run-dm-compatibility-test

@WizardXiao
Copy link
Contributor Author

/run-integration-test

@WizardXiao
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@WizardXiao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a4ec3b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@WizardXiao
Copy link
Contributor Author

/run-all-tests

2 similar comments
@WizardXiao
Copy link
Contributor Author

/run-all-tests

@WizardXiao
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 781049f into pingcap:master May 13, 2022
@WizardXiao WizardXiao mentioned this pull request May 17, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WizardXiao @ti-chi-bot @codecov-commenter @D3Hunter @Ehco1996