Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc): add processor etcd worker delay integration test #5470

Merged
merged 13 commits into from
May 24, 2022
Merged

test(ticdc): add processor etcd worker delay integration test #5470

merged 13 commits into from
May 24, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented May 19, 2022

What problem does this PR solve?

Issue Number: ref #5326

What is changed and how it works?

add processor etcd worker delay integration test

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2022
@sdojjy
Copy link
Member Author

sdojjy commented May 19, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2022
@sdojjy sdojjy added area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. and removed needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. labels May 19, 2022
@sdojjy sdojjy self-assigned this May 19, 2022
@sdojjy sdojjy requested a review from liuzix May 19, 2022 04:08
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. label May 23, 2022
@3AceShowHand 3AceShowHand self-requested a review May 23, 2022 03:15
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae88e47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #5470 (6e9e48f) into master (e62fbea) will decrease coverage by 0.0830%.
The diff coverage is 72.0430%.

Flag Coverage Δ
cdc 61.6364% <ø> (+0.1499%) ⬆️
dm 51.9738% <72.0430%> (+0.0075%) ⬆️
engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5470        +/-   ##
================================================
- Coverage   56.3160%   56.2329%   -0.0831%     
================================================
  Files           675        530       -145     
  Lines         78594      69847      -8747     
================================================
- Hits          44261      39277      -4984     
+ Misses        30143      26835      -3308     
+ Partials       4190       3735       -455

@sdojjy
Copy link
Member Author

sdojjy commented May 24, 2022

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 58f8a9e into pingcap:master May 24, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5548.

@sdojjy sdojjy deleted the add-processor-etcd-work-delay-integration-test branch May 24, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@sdojjy sdojjy

Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdojjy @ti-chi-bot @asddongmen @codecov-commenter @3AceShowHand