Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: parse start-time using upstream timezone #5476

Merged
merged 7 commits into from
May 19, 2022
Merged

dm: parse start-time using upstream timezone #5476

merged 7 commits into from
May 19, 2022

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5471

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

fix parsing task start-time using downstream timezone problem.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2022
@D3Hunter
Copy link
Contributor Author

/cc @lance6716 @Ehco1996

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. and removed do-not-merge/needs-triage-completed labels May 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
@D3Hunter
Copy link
Contributor Author

/run-verify
/run-dm-integration-test

Ehco1996
Ehco1996 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 70a74c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@D3Hunter
Copy link
Contributor Author

/run-verify
/run-dm-integration-test

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

2 similar comments
@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f2cf3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

/run-verify
/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@D3Hunter: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter
Copy link
Contributor Author

/run-verify
/run-dm-integration-test

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter D3Hunter merged commit 6148c45 into pingcap:master May 19, 2022
@D3Hunter D3Hunter deleted the fix-start-time-tz branch May 19, 2022 16:32
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2022
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#5476
3723033 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5485.

@D3Hunter D3Hunter added the area/dm Issues or PRs related to DM. label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm: start-time should use upstream timezone
4 participants
@D3Hunter @ti-chi-bot @lance6716 @Ehco1996