Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): use 1 minute kv retry time #5499

Merged
merged 4 commits into from
May 23, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Use 1 minute for kv retry time to ensure ScanRegion successfully
even if there are some region has no leader for a long time.

Issue Number: close #5230

What is changed and how it works?

Use a large default timeout.

Check List

Tests

  • Unit test

Release note

None

Use 1 minute for kv retry time to ensure ScanRegion successfully
even if there are some region has no leader for a long time.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • CharlesCheung96

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 92c5f0a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5529.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5530.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5531.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5532.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5533.

@overvenus overvenus added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 24, 2022
@overvenus
Copy link
Member Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5564.

@overvenus
Copy link
Member Author

@ti-chi-bot

overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 20, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 20, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 20, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 23, 2022
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 affects-6.0 affects-6.1 area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScanRegions total retry time is too short
5 participants