Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric[engine]:Replace framework metric #5526

Merged
merged 10 commits into from
May 24, 2022
Merged

metric[engine]:Replace framework metric #5526

merged 10 commits into from
May 24, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5525

What is changed and how it works?

replace prometric metric with multi-projects/tasks metric

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2022
@maxshuang maxshuang added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/engine Issues or PRs related to Dataflow Engine. labels May 23, 2022
@maxshuang maxshuang changed the title Replace framework metric metric[engine]:Replace framework metric May 23, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #5526 (d0a8058) into master (fcea4d5) will increase coverage by 5.5292%.
The diff coverage is 62.6641%.

❗ Current head d0a8058 differs from pull request most recent head a853a1c. Consider uploading reports for the commit a853a1c to get more accurate results

Flag Coverage Δ
cdc 61.6061% <62.6641%> (+0.4580%) ⬆️
dm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5526        +/-   ##
================================================
+ Coverage   56.0768%   61.6061%   +5.5292%     
================================================
  Files           535        291       -244     
  Lines         70143      30807     -39336     
================================================
- Hits          39334      18979     -20355     
+ Misses        27078      10198     -16880     
+ Partials       3731       1630      -2101     

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 24, 2022
@maxshuang maxshuang added the status/ptal Could you please take a look? label May 24, 2022
engine/pkg/promutil/util.go Outdated Show resolved Hide resolved
engine/pkg/promutil/util.go Outdated Show resolved Hide resolved
engine/lib/base_jobmaster.go Outdated Show resolved Hide resolved
engine/lib/master.go Outdated Show resolved Hide resolved
engine/lib/worker.go Outdated Show resolved Hide resolved
maxshuang and others added 3 commits May 24, 2022 15:02
Co-authored-by: amyangfei <amyangfei@gmail.com>
Co-authored-by: amyangfei <amyangfei@gmail.com>
@maxshuang maxshuang requested a review from amyangfei May 24, 2022 07:21
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 24, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9bb5a72

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2022
@ti-chi-bot ti-chi-bot merged commit b160a9a into pingcap:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace framework prometric metric with multi-projects/tasks metric
5 participants